Skip to content

Tighten condition check for VirtualNetworkInterface.Status.Conditions #684

Description

@yanleizhao-vmware

Please describe the solution you would like.
waitForReadyNCPNetworkInterface checks for VirtualNetworkInterface.Status.Conditions using strings.Contains(cond.Type, "Ready") and strings.Contains(cond.Status, "True"), is there any historical reason (or futuristic thinking?) to use Contains instead of equality check? If not, can we tighten the check?

Is there anything else you would like to add?

N/A.

Please tell us about your environment.

N/A.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions