Add missing labels for antreaconfig from clusterbootstrap#4555
Conversation
Signed-off-by: Hang Yan <yhang@vmware.com>
Signed-off-by: Hang Yan <yhang@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #4555 +/- ##
==========================================
- Coverage 49.78% 48.91% -0.88%
==========================================
Files 453 483 +30
Lines 45379 47544 +2165
==========================================
+ Hits 22594 23255 +661
- Misses 20632 22082 +1450
- Partials 2153 2207 +54
... and 35 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shyaamsn
left a comment
There was a problem hiding this comment.
LGTM. Please ensure all the tests in CAPA pipeline passes. Then this can be merged.
|
We also need to update the label in the upgrade case. Need to call this same method to update label during upgrade here https://github.com/vmware-tanzu/tanzu-framework/blob/main/addons/controllers/clusterbootstrap_controller.go#L431 |
Signed-off-by: Hang Yan <yhang@vmware.com>
updated. |
|
/test install-vc7,upgrade-vc7 |
What this PR does / why we need it
Which issue(s) this PR fixes
In the last version bump, antrea controller relies on a package label to working normally. But in cert cases(cb and antreaconfig created from kubectl, the label is missing). This patch added the missing label from clusterboostrap clone
Fixes # TKG-18782
This is also an alternative solution compared to #4544
Describe testing done for PR
Test done in a Live tanzu env
Release note
Additional information
Special notes for your reviewer