Fix YTT processing for passwords with yaml special chars#4548
Conversation
|
You have successfully added a new Trivy configuration |
|
Cluster Generation A/B Results: |
tenczar
force-pushed
the
topic/ntenczar/password_bug
branch
from
5090ab7 to
f48083e
Compare
|
Cluster Generation A/B Results: |
Fixes our ytt processor so that password values are not passed to the yaml parser as yaml. This prevents the password from being interpreted as yaml, which could lead to template errors and other failures.
tenczar
force-pushed
the
topic/ntenczar/password_bug
branch
from
f48083e to
f32efce
Compare
|
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #4548 +/- ##
==========================================
- Coverage 49.78% 48.92% -0.87%
==========================================
Files 453 483 +30
Lines 45379 47503 +2124
==========================================
+ Hits 22594 23243 +649
- Misses 20632 22060 +1428
- Partials 2153 2200 +47
... and 35 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
3 participants
Fixes our yaml processor so that passwords are passed to ytt as string values. This fixes a bug that would occur when a special characters in password would act like yaml structures and cause parsing errors. Examples: any password starting with an
!would be empty in ytt as yaml treats a string starting with the bang as a tag, Any password ending with a colon (:) would be treated as an empty map and not a string causing parsing errors.What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer