Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

[release-0.28] cherry-pick 4467 : Support additional image registries with self-signed CA certificates#4479

Open
alfredthenarwhal wants to merge 1 commit into
release-0.28from
cherry-pick-release-0.28-5b41308a46069faeedf2f243b9cd3e6c8d429247
Open

[release-0.28] cherry-pick 4467 : Support additional image registries with self-signed CA certificates#4479
alfredthenarwhal wants to merge 1 commit into
release-0.28from
cherry-pick-release-0.28-5b41308a46069faeedf2f243b9cd3e6c8d429247

Conversation

@alfredthenarwhal
Copy link
Copy Markdown

Cherry-pick of #4467 into release-0.28 branch

…4467)

Users could have application images in private registries with self-signed
CA certificates, this patch configure containerd TLS settings for them.

For image registries with a public CA certificates, no additional
configurations are required for containerd.

Legacy config file exposes 3 registries given it can not hold a list object.
To add more registries, edit generated Cluster variable.
@alfredthenarwhal alfredthenarwhal requested a review from a team as a code owner March 15, 2023 04:36
@alfredthenarwhal alfredthenarwhal requested review from a team March 15, 2023 04:36
@alfredthenarwhal alfredthenarwhal added backports/release-0.28 Back-ported PRs into release-0.28 branch cherry-pick/release-0.28 PRs to be cherry-picked into release-0.28 branch cla-not-required ok-to-merge PRs should be labelled with this before merging labels Mar 15, 2023
@github-actions
Copy link
Copy Markdown

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4479/20230315045122/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-0.28@0e67047). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release-0.28    #4479   +/-   ##
===============================================
  Coverage                ?   48.78%           
===============================================
  Files                   ?      482           
  Lines                   ?    47141           
  Branches                ?        0           
===============================================
  Hits                    ?    23000           
  Misses                  ?    21973           
  Partials                ?     2168           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backports/release-0.28 Back-ported PRs into release-0.28 branch cherry-pick/release-0.28 PRs to be cherry-picked into release-0.28 branch cla-not-required ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants