Conversation
masap
force-pushed
the
fix-2032
branch
2 times, most recently
from
November 18, 2025 07:10
3118719 to
c4f5ef7
Compare
Contributor
Author
|
Hello @farazkhawaja could you review this PR as well? We are currently using SPDY for sonobuoy, but since SPDY is deprecated, I implemented an alternative. |
farazkhawaja
approved these changes
May 21, 2026
Contributor
Author
|
This was apporved by @farazkhawaja and I fixed CI error. Could anybody merge this? |
Sonobuoy uses SPDY to retrieve results, but SPDY is already deprecated [1], and some of my customers block SPDY. Kubernetes migrated from SPDY to WebSocket starting with version 1.31 [2]. Therefore, we will also introduce WebSocket for sonobuoy. To maintain backward compatibility, it will fallback to SPDY if the WebSocket connection fails. [1] https://en.wikipedia.org/wiki/SPDY [2] https://kubernetes.io/blog/2024/08/20/websockets-transition/ Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
Contributor
Author
|
@ShashankGirish Hello. Could you review this PR as well? Current sonobuoy is using SPDY to download result but SPDY is deprecated. We need to migrate to WebSocket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sonobuoy uses SPDY to retrieve results, but SPDY is already deprecated [1], and some of my customers block SPDY. Kubernetes migrated from SPDY to WebSocket starting with version 1.31 [2]. Therefore, we will also introduce WebSocket for sonobuoy. To maintain backward compatibility, it will fallback to SPDY if the WebSocket connection fails.
[1] https://en.wikipedia.org/wiki/SPDY
[2] https://kubernetes.io/blog/2024/08/20/websockets-transition/
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: