This repository was archived by the owner on Jul 1, 2021. It is now read-only.
ManagedObject.wait_until: replace WaitForUpdates with WaitForUpdatesEx#140
Open
evanchaoli wants to merge 1 commit intovmware-archive:masterfrom
Open
ManagedObject.wait_until: replace WaitForUpdates with WaitForUpdatesEx#140evanchaoli wants to merge 1 commit intovmware-archive:masterfrom
evanchaoli wants to merge 1 commit intovmware-archive:masterfrom
Conversation
…tesEx. WaitForUpdates has been depracted since 4.1, WaitForUpdatesEx is the offical replacement. WaitForUpdatesEx has an option to specify wait timeout. We recently often encounter ReadTimeout error against wait_until because some task took more than 10 minutes to finish, but local HTTP read timeout is 10 minutes. After this fix, we no longer see the error.
Contributor
|
Sorry @evanchaoli! I somehow missed this! I'll get this reviewed and hopefully merged and released sometime next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WaitForUpdates has been depracted since 4.1, WaitForUpdatesEx is the offical replacement. WaitForUpdatesEx has an option to specify wait timeout. We recently often encounter ReadTimeout error against wait_until because some task took more than 10 minutes to finish, but local HTTP read timeout is 10 minutes. After this fix, we no longer see the error.