fix: use @clerk/backend for backfill script clerk client#6056
Merged
Conversation
❌ 1 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
⚡ Lighthouse — Web
Tested URL: https://pr-6056-www.vm6.ai/ · Full report |
The backfill script runs outside Next.js runtime via tsx, so `createClerkClient` from `@clerk/nextjs/server` is not available at ESM runtime (only re-exported in type declarations). Switch to importing directly from `@clerk/backend` which is the actual source package. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Dry-run mode should still read from Clerk API to show what would be backfilled. Previously it skipped Clerk initialization entirely, making dry-run output useless (0 processed). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lancy
force-pushed
the
fix/backfill-clerk-import
branch
from
1e7d8bf to
7147476
Compare
Contributor
Author
Code Review: PR #6056SummaryThis PR fixes a runtime import error in the backfill script ( Two well-separated commits:
Key FindingsCritical Issues (P0)
High Priority (P1)
Testing ReviewCoverage
Convention Compliance
Testing Verdict: AdequateExisting tests cover all changed behavior. The import fix is a runtime environment issue (tsx vs Next.js) that wouldn't be caught by vitest-based tests, but the PR description confirms manual verification ( Bad Smell AnalysisAll 17 bad smell categories checked — zero violations. The PR actually improves code quality:
RecommendationsNo action items. This is a clean, well-scoped bug fix. Verdict: LGTMFull review details: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createClerkClientimport in backfill script — the script runs viatsxoutside Next.js runtime, so@clerk/nextjs/serverdoesn't exportcreateClerkClientat ESM runtime (only in type declarations)@clerk/backendwhich is the actual source package@clerk/backendas explicit dependencyContext
The backfill script (#5972, PR #5973) was merged with
import { createClerkClient } from "@clerk/nextjs/server"which fails at runtime:Test plan
tsx scripts/migrations/005-backfill-clerk-metadata/backfill.tsruns successfully (dry-run mode)🤖 Generated with Claude Code