Skip to content

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Oct 18, 2025

Purpose

  • Currently, MultiHeadAttention become quite messy because we're using upstream FA and attention backend selection logic is quite coupling.
  • This PR aims to refactor the MultiHeadAttention interface to decouple backend selection and support attention mask like Qwen2-VL ViT.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Isotr0py <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant