[BugFix] fix graph partition signature #27139
Conversation
Signed-off-by: Boyuan Feng <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a monkey patch for get_graph_partition_signature in PyTorch 2.9 to address a bug related to graph partitioning, which fixes the test_attn_quant test. The changes in the test file reflect an update to the logging infrastructure. The core change in vllm/env_override.py seems correct in its intent to backport a fix. However, there is a misleading comment for the new monkey patch that should be corrected to improve maintainability.
tests/compile/test_fusions_e2e.py
Outdated
| ) | ||
|
|
||
| with caplog_mp_spawn(logging.DEBUG) as log_holder: | ||
| with caplog_vllm.at_level(logging.DEBUG): |
There was a problem hiding this comment.
This test does not use mp. caplog_mp_spawn would also fail for dynamo graph partition.
There was a problem hiding this comment.
I wonder if that's just on your machine - for me even tp=1 tests used MP. I'll enable CI and we can see. But I think we should probably just do both, and we can investigate later
Signed-off-by: Boyuan Feng <[email protected]>
tests/compile/test_fusions_e2e.py
Outdated
| ) | ||
|
|
||
| with caplog_mp_spawn(logging.DEBUG) as log_holder: | ||
| with caplog_vllm.at_level(logging.DEBUG): |
There was a problem hiding this comment.
I wonder if that's just on your machine - for me even tp=1 tests used MP. I'll enable CI and we can see. But I think we should probably just do both, and we can investigate later
ProExpertProg
added
the
ready
Signed-off-by: Boyuan Feng <[email protected]>
|
@ProExpertProg yes we should use |
ProExpertProg
added this to the
vllm==v0.12.0/torch==2.9.0 compilation improvements milestone
Signed-off-by: Boyuan Feng <[email protected]>
Signed-off-by: Boyuan Feng <[email protected]>
2 participants
A pytorch 2.9 monkey patch to fix
test_attn_quant. See pytorch/pytorch#165815