-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[Bugfix] Fix incorrect kv cache metrics in grafana.json #27133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
Documentation preview: https://vllm--27133.org.readthedocs.build/en/27133/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the grafana.json file to use the correct Prometheus metric name for GPU cache usage. The old metric name gpu_cache_usage_perc
is replaced with the new metric name kv_cache_usage_perc
. This change ensures that the Grafana dashboard accurately reflects the current metrics being exposed by vLLM.
"uid": "${DS_PROMETHEUS}" | ||
}, | ||
"editorMode": "code", | ||
"expr": "vllm:gpu_cache_usage_perc{model_name=\"$model_name\"}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metric name vllm:gpu_cache_usage_perc
is outdated and should be updated to vllm:kv_cache_usage_perc
to align with the latest metrics. This discrepancy could lead to incorrect monitoring and alerting.
It's critical to ensure that monitoring dashboards use the correct metric names to provide accurate insights into system performance and resource utilization.
"expr": "vllm:kv_cache_usage_perc{model_name=\"$model_name\"}"
Thank you! Just need to fix the DCO issue:
Since you'll be making that update, would you mind also searching and replacing in |
Signed-off-by: Fangping Shi <[email protected]>
d98eae4
to
f3c5ca8
Compare
Signed-off-by: Fangping Shi <[email protected]>
Thanks. I replaced occurrence under that folder too. |
Purpose
Current grafana.json is using an outdated prometheus metrics name
gpu_cache_usage_perc
. The lastest metrics is namedkv_cache_usage_perc
. See hereTest Plan
Verified in my own grafana dashboard
Test Result
Before
After
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.