Skip to content

Conversation

fangpings
Copy link

@fangpings fangpings commented Oct 17, 2025

Purpose

Current grafana.json is using an outdated prometheus metrics name gpu_cache_usage_perc. The lastest metrics is named kv_cache_usage_perc. See here

Test Plan

Verified in my own grafana dashboard

Test Result

Before

Screenshot 2025-10-17 at 4 27 30 PM

After

Screenshot 2025-10-17 at 4 27 45 PM
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify
Copy link

mergify bot commented Oct 17, 2025

Documentation preview: https://vllm--27133.org.readthedocs.build/en/27133/

@mergify mergify bot added the documentation Improvements or additions to documentation label Oct 17, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the grafana.json file to use the correct Prometheus metric name for GPU cache usage. The old metric name gpu_cache_usage_perc is replaced with the new metric name kv_cache_usage_perc. This change ensures that the Grafana dashboard accurately reflects the current metrics being exposed by vLLM.

"uid": "${DS_PROMETHEUS}"
},
"editorMode": "code",
"expr": "vllm:gpu_cache_usage_perc{model_name=\"$model_name\"}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The metric name vllm:gpu_cache_usage_perc is outdated and should be updated to vllm:kv_cache_usage_perc to align with the latest metrics. This discrepancy could lead to incorrect monitoring and alerting.

It's critical to ensure that monitoring dashboards use the correct metric names to provide accurate insights into system performance and resource utilization.

          "expr": "vllm:kv_cache_usage_perc{model_name=\"$model_name\"}"

@markmc
Copy link
Member

markmc commented Oct 20, 2025

Thank you!

Just need to fix the DCO issue:

always include Signed-off-by: Author Name [email protected] in every commit message

Since you'll be making that update, would you mind also searching and replacing in examples/online_serving/dashboards/perses/ too? No need to test

@fangpings
Copy link
Author

Thank you!

Just need to fix the DCO issue:

always include Signed-off-by: Author Name [email protected] in every commit message

Since you'll be making that update, would you mind also searching and replacing in examples/online_serving/dashboards/perses/ too? No need to test

Thanks. I replaced occurrence under that folder too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants