-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Add missing opentelemetry dependency to base docker image #27109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a critical startup crash caused by missing opentelemetry
modules when the --otlp-traces-endpoint
flag is used. The fix involves adding the necessary opentelemetry
packages to the requirements/common.txt
file. I have added a review comment to highlight the importance of keeping dependencies up-to-date and suggest a way to automate this process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR.
Added OpenTelemetry dependencies for tracing support. Signed-off-by: Aymen Djellal <[email protected]>
I think the version conflict with ray has been resolved, might be worth just adding it to the default set of dependencies in requirements/common.txt |
Signed-off-by: Aymen Djellal <[email protected]>
You are right, I tried removing the upper limit and it seems to work fine for me |
Purpose
Fix #26491
When using the flag
--otlp-traces-endpoint
, the server crashes on startup with an error[1;36m(APIServer pid=1) [0;0m ModuleNotFoundError: No module named 'opentelemetry'
This PR adds the missing modules based on the existing opentelemetry documentation
Test Plan
Rebuild the docker image with the extra
Test Result
No more crashes on startup
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.