Skip to content

Conversation

@wxh571001500
Copy link

@wxh571001500 wxh571001500 commented Nov 20, 2025

What this PR does / why we need it?

Previously, when adapting vllm-ascend to models such as Qwen-Next, users needed to install the triton_ascend dependency separately. Therefore, to improve usability, the dependency is now included in requirements.txt and installed along with vllm-ascend.

Does this PR introduce any user-facing change?

nope

How was this patch tested?

After installing vllm-ascend, we can use “pip list” to observe that triton-ascend is also installed synchronously.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds triton-ascend as a dependency in requirements.txt. However, the corresponding pyproject.toml file was not updated. To maintain consistency and prevent potential build issues, this dependency should also be added to pyproject.toml's build-system.requires list, as is the convention in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant