Skip to content

Conversation

@zhangxinyuehfad
Copy link
Contributor

@zhangxinyuehfad zhangxinyuehfad commented Nov 18, 2025

What this PR does / why we need it?

Add accuracy nightly test for new models:

PaddlePaddle/ERNIE-4.5-21B-A3B-PT
LLM-Research/Molmo-7B-D-0924
LLM-Research/gemma-2-9b-it
LLM-Research/gemma-3-4b-it
Shanghai_AI_Laboratory/internlm-7b
llava-hf/llava-1.5-7b-hf

Does this PR introduce any user-facing change?

How was this patch tested?

accuracy test:
https://github.com/vllm-project/vllm-ascend/actions/runs/19815806720?pr=4262
image
image

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@vllm-ascend-ci vllm-ascend-ci added ready-for-test start test by label for PR accuracy-test enable all accuracy test for PR labels Nov 18, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds accuracy nightly tests for several new models by introducing their respective YAML configuration files and updating the main test list. Additionally, it modifies the test script to allow for configurable dtype settings. My review identified a critical issue with a filename mismatch that would cause a test to fail, and I've also provided a suggestion to improve code maintainability in the Python test script.

@zhangxinyuehfad zhangxinyuehfad force-pushed the zxy_accuracy branch 10 times, most recently from 35fdb50 to ad98ff4 Compare November 19, 2025 08:55
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@wangxiyuan wangxiyuan merged commit b6afec7 into vllm-project:main Dec 1, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants