[NPU] Support Kimi-K2-Thinking model - #399
Open
yuxinshan wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces NPU support and compatibility enhancements, including a pure PyTorch fallback for int4 quantization, safe NPU device routing, and a patch for handling Kimi K2 architectures. The review feedback highlights critical issues that need to be addressed: correcting the invalid deepdim parameter to keepdim in the quantization fallback function to prevent runtime errors, safely checking for NPU availability to avoid AttributeError on non-NPU environments, and adding a defensive check for None bridge instances.
Documentation build overview
47 files changed ·
|
yuxinshan
force-pushed
the
kimi_k2_thinking
branch
from
August 26, 2026 03:16
2597044 to
7098b3b
Compare
3 tasks
yuxinshan
force-pushed
the
kimi_k2_thinking
branch
from
August 28, 2026 03:02
7098b3b to
0e29fe9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support Kimi-K2-Thinking model.
Related issue: #395
Architecture
To solve the problem of the parallel mode:
To solve the problem of the megatron to hf:
To support Kimi-K2-Thinking model:
Validation