Skip to content

Update PLaMo 2 Translate serve command#595

Open
haic0 wants to merge 1 commit into
vllm-project:mainfrom
haic0:haic0/update-plamo2-translate-command
Open

Update PLaMo 2 Translate serve command#595
haic0 wants to merge 1 commit into
vllm-project:mainfrom
haic0:haic0/update-plamo2-translate-command

Conversation

@haic0

@haic0 haic0 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adjust PLaMo 2 Translate to the provided trust-remote-code and TP=4 launch command.
  • Aligns the recipe launch guidance with the provided vLLM serve command.

Test plan

  • Ran node scripts/build-recipes-api.mjs on the complete validated recipe update set.

Made with Cursor

Adjust PLaMo 2 Translate to the provided trust-remote-code and TP=4 launch command.

Signed-off-by: haic0 <haichzha@amd.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vllm-recipes Ready Ready Preview, Comment Jun 29, 2026 1:52pm

Request Review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the configuration and guide for the plamo-2-translate model to default to a tensor parallelism of 4. However, the reviewer notes that hardcoding tp: 4 in strategy_overrides breaks dynamic tensor parallelism scaling for single-GPU setups and recommends removing this override to allow the TP size to adapt dynamically to the selected hardware.

Comment on lines +42 to +44
strategy_overrides:
single_node_tp:
tp: 4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Hardcoding tp: 4 in strategy_overrides forces the interactive CommandBuilder to always generate --tensor-parallel-size 4, even when a user selects a single-GPU hardware profile (such as an RTX 4090 or L40S) which is explicitly supported according to the guide. This breaks the dynamic tensor parallelism scaling of the single_node_tp strategy (which normally scales TP to match the selected hardware's GPU count). Removing this override allows the TP size to dynamically adapt to the selected hardware profile.

strategy_overrides: {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants