Skip to content

fix: add timeouts to build-time network requests #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatrixNeoKozak wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add timeouts to build-time network requests #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b09bb0
fix: add timeouts to build-time network requests
MatrixNeoKozak Jun 18, 2026
1e4f9d7
refactor: use native AbortSignal.timeout in build-time scripts
Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/fetch-hf-dates.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ async function fetchCreatedAt(modelId) {
try {
const res = await fetch(`https://huggingface.co/api/models/${modelId}`, {
headers: { "User-Agent": "vllm-recipes-build/1.0" },
signal: AbortSignal.timeout(10000),
});
if (!res.ok) return null;
const data = await res.json();
Expand Down
5 changes: 4 additions & 1 deletion scripts/fetch-provider-logos.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ fs.mkdirSync(OUT, { recursive: true });
async function fetchOrgAvatarUrl(org) {
const res = await fetch(`https://huggingface.co/${org}`, {
headers: { "User-Agent": "vllm-recipes-build/1.0" },
signal: AbortSignal.timeout(10000),
});
const html = await res.text();
const match = html.match(/cdn-avatars\.huggingface\.co\/[^"&]+/);
Expand Down Expand Up @@ -58,7 +59,9 @@ for (const [org, meta] of Object.entries(targets)) {
failed++;
continue;
}
const imgRes = await fetch(avatarUrl);
const imgRes = await fetch(avatarUrl, {
signal: AbortSignal.timeout(10000),
});
const buffer = Buffer.from(await imgRes.arrayBuffer());
fs.writeFileSync(localPath, buffer);
console.log(`✓ ${org} (${buffer.length}B)`);
Expand Down