v3: make V3 the default compiler on macOS and expand compatibility - #28007
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vlib/v3the default for macOS user compilation and test commands-old-compileras the explicit V1 escape hatch and remove automatic fallback after V3 errorsmasterV3 changes and checker splitWhy
The macOS default can only move to V3 if ordinary programs are handled by V3 directly and failures are reported without silently retrying with V1. This branch advances the V3 passing manifest and fills compatibility gaps found while compiling the existing V test suite.
Impact
On macOS, supported user builds and tests now use V3 by default. Users can still select V1 explicitly with
-old-compiler. Compiler failures stay within V3 and preserve V3 diagnostics.This is a progress PR and is intentionally left as a draft.
Validation
Passed locally on macOS:
./vnewfrom the merged compiler sources with the old compiler bootstrap pathgit diff --check./vnew -nocache cmd/v/macos_v3_test.v./vnew -nocache vlib/v3/tests/aoc_compat_codegen_test.v./vnew -nocache vlib/v/tests/failing_tests_test.v./vnew -nocache vlib/v/tests/consts/const_referencing_each_other_inside_anon_fns_test.v./vnew -nocache vlib/v/tests/consts/const_array_fixed_test.v./vnew -nocache vlib/v/tests/consts/const_fixed_array_containing_references_to_itself_test.vKnown incomplete validation/compatibility:
vlib/v3/tests/mut_param_reassign_codegen_test.vstill fails because mutablestringparameters are rejectedvlib/v/, inout, and C output suites have not yet been completed on this branch