Add window-closed subscribe event - #48
Merged
Merged
Conversation
Ports nikitabobko#2181. Unioned with the fork's existing workspace-layout-changed and window-moved-to-workspace subscribe events. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports nikitabobko#2181.
Adds a
window-closedevent toaerospace subscribe, fired when a window is closed (includeswindowIdandworkspace). Mirrors the fork's existingwindow-moved-to-workspace(#40) andworkspace-layout-changedsubscribe events.The upstream PR touches the same event-registration files the fork already extended, so it was applied with
git apply --3wayand the additive conflicts resolved by union — the fork keepsworkspace-layout-changed+window-moved-to-workspaceand gainswindow-closed:ServerEvent.swift— addedwindowClosedfactorySubscribeCmdArgs.swift— addedServerEventType.windowClosedcasesubscriptions.swift— added to the non-broadcast-on-subscribe switchMacWindow.swift— firesbroadcastEvent(.windowClosed(...))on close (applied clean)Docs
docs/aerospace-subscribe.adoc— event listgrammar/commands-bnf-grammar.txt—<event>ruleTest coverage
SubscribeCmdArgsTestupdated with the new possible-values list../build-debug.sh -Xswiftc -warnings-as-errors✅./swift-test.sh✅🤖 Generated with Claude Code