[release-23.0] vreplication: prevent vttablet panic on malformed RowChange images (#20377)#20408
Open
vitess-bot[bot] wants to merge 3 commits into
Open
[release-23.0] vreplication: prevent vttablet panic on malformed RowChange images (#20377)#20408vitess-bot[bot] wants to merge 3 commits into
RowChange images (#20377)#20408vitess-bot[bot] wants to merge 3 commits into
Conversation
vitess-bot
Bot
added
Type: Bug
Backport
Contributor
Author
|
Hello @timvaillancourt, there are conflicts in this backport. Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually. Make sure you replace |
vitess-bot
Bot
requested review from
arthurschreiber,
beingnoble03,
mhamza15,
pourtorabehsan,
rohit-nayak-ps,
shlomi-noach and
timvaillancourt
release-23.0 lacks the bulk-insert/marshal tests and benchmarks that exist on main, so the cherry-pick conflicted on surrounding context. Keep the branch's existing test file and add only the TestApplyBulkDeleteChanges test that PR #20377 introduced. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Comment on lines
+264
to
+268
| log.Error("caught panic", | ||
| slog.String("workflow", workflow), | ||
| slog.String("where", where), | ||
| slog.Any("panic", x), | ||
| slog.String("stack", string(tb.Stack(4))), |
Comment on lines
601
to
602
| vals := sqltypes.MakeRowTrusted(tp.Fields, rowDelete.Before) | ||
| if pkIndex == -1 { | ||
| for i := range vals { | ||
| if tp.PKIndices[i] { | ||
| pkIndex = i | ||
| break | ||
| } | ||
| } | ||
| } | ||
| addedSize := int64(len(vals[pkIndex].Raw()) + 2) // Plus 2 for the comma and space |
Contributor
|
Promptless prepared a documentation update related to this change. Triggered by PR #20408 (backport of #20377) Added a changelog entry documenting the VReplication fix that prevents a vttablet panic on malformed Review: vreplication: prevent vttablet panic on malformed RowChange images |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #20377