fix: clean skips already merged or closed PRs and reports why a close failed - #151
Merged
Conversation
|
Warning Review limit reachedNext included review available in 18 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
vitali87
force-pushed
the
fix/clean-skips-merged-prs
branch
from
August 30, 2026 19:24
f83ef7d to
61fd281
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After
pr-split merge, runningpr-split cleanwarnedCould not close PR #Nfor every merged PR —gh pr closerefuses a merged PR — and dropped the reason; an already-closed PR (gh exits 0) was counted as newly closed. With #55's completeness check that also meant a fully merged split could never remove its plan file._cleanup_git_statenow asksget_pr_statefirst:MERGED/CLOSEDPRs logPR #N is already merged, nothing to close, are not closed again, and count as done; a real close failure logsCould not close PR #N: <reason>. An unknown state (fetch error) still attempts the close so the real error reaches the user.Stacked on #55 (
fix/reliable-branch-cleanup).Test plan
TestCleanupSkipsFinishedPrs: merged + closed + open trio → only the open one is closed, no warnings, plan removed; a close failure keeps the plan and includes the reason — both fail on the baseget_pr_stateas OPENNoted by the review, not in this PR: after
merge --delete-branchthe branch half of #55's completeness check has the same "already gone" problem.