fix: reject a remote-tracking --base up front instead of failing at PR creation - #144
Merged
Conversation
|
Warning Review limit reachedNext included review available in 44 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pr-split split feature --base origin/mainpassed input validation (git rev-parse --verify origin/mainsucceeds), so the whole split ran — branches created and pushed, plan saved withbase_branch="origin/main"— and only failed at the very end whengh pr create --base origin/mainwas rejected because GitHub has no branch of that name. The same applied to a tag or a SHA, and toexecuteon such a plan.A new
_require_local_branch(base)refuses anything that is notrefs/heads/<base>before any worktree, prompt or branch creation, in bothsplitandexecute:The "for example" hint is only added when the input is
<remote>/<name>(orrefs/remotes/<remote>/<name>) for a remote listed bygit remote; tags and SHAs get the message without a bogus suggestion.Test plan
TestValidateInputs:origin/mainrejected with the hint, tag/SHA/feature/topicrejected without one,refs/remotes/origin/mainsuggestsmain, local base checks the branch head;executerefuses an old plan with a remote-tracking base before the confirm prompt — all fail on mainorigin/mainis still accepted