fix: count every hunk of a WHOLE_FILE assignment in LOC estimates - #109
Closed
vitali87 wants to merge 1 commit into
Closed
fix: count every hunk of a WHOLE_FILE assignment in LOC estimates#109vitali87 wants to merge 1 commit into
vitali87 wants to merge 1 commit into
Conversation
…tching coverage validation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recompute_estimated_locsummed onlyassignment.hunk_indices, whilevalidate_coverageand the reconstructor treat aWHOLE_FILEassignment as covering every hunk of the file whatever its list says. The LLM path can emitWHOLE_FILEwith an empty or partial list, so such a plan passed coverage but got a too-smallestimated_locand then failedvalidate_locwithLOC_MISMATCH.recompute_estimated_locnow countsrange(hunk_count)for everyWHOLE_FILEassignment (the list itself is left untouched);PARTIAL_HUNKSis unchanged.Stacked on #108 (
fix/move-assignment-recompute-loc).Test plan
test_chunker.py: WHOLE_FILE with[]and[0]on a two-hunk file now estimate 2 lines (both fail on the base with 0 / 1), full list matches an equivalent PARTIAL_HUNKS group, unknown path stays 0Follow-up noted by the review (not in this PR):
assign_uncovered_hunksandvalidate_no_conflictsstill read onlyhunk_indices.