Remove unused drive auth page

[viseshrp]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the application's Google Drive integration by eliminating the previously unused standalone Drive authentication page. All authentication and backup management responsibilities are now consolidated within the existing options page, simplifying the architecture and reducing code overhead. Accompanying this removal are comprehensive updates to documentation and test configurations. Additionally, minor refactorings were performed to internalize certain utility exports, and the E2E tests for tab restoration were made more resilient.

Highlights

• Removed Standalone Drive Auth Page: The dedicated entrypoints/drive-auth/ directory, which contained the HTML, TypeScript logic, and styles for a standalone Google Drive authentication page, has been completely removed. This streamlines the application by consolidating auth functionality.
• Documentation and Configuration Clean-up: All references to the removed drive-auth page have been purged from various documentation files (README.md, TESTING.md, docs/DRIVE_BACKUP_PLAN.md, docs/DRIVE_BACKUP_SPEC.md, docs/architecture.md) and the vitest.config.ts file.
• Internalized Utility Exports: Several types and functions across entrypoints/drive/drive_backup.ts, entrypoints/drive/types.ts, entrypoints/options/settings_page.ts, and entrypoints/ui/notifications.ts were changed from exported to internal, indicating they are no longer intended for external consumption within the module.
• Improved E2E Tab Restoration Tests: End-to-end tests for tab restoration were enhanced to correctly handle pendingUrl for newly created tabs and to utilize expect.poll for more robust waiting conditions, improving test stability.

Changelog

• README.md
  • Removed description of the entrypoints/drive-auth/ directory.
• TESTING.md
  • Updated coverage exclusion rules to remove references to the drive-auth entrypoints.
• docs/DRIVE_BACKUP_PLAN.md
  • Removed the 'Auth Tab' section.
  • Updated coverage exclusion notes.
• docs/DRIVE_BACKUP_SPEC.md
  • Removed references to the standalone auth page in implementation boundaries.
  • Updated error behavior descriptions.
• docs/architecture.md
  • Updated the 'Drive backup modules' section to remove entrypoints/drive-auth/.
  • Clarified the role of the options page.
  • Updated troubleshooting guidance.
• entrypoints/drive-auth/drive_auth_page.ts
  • Removed the entire file, which contained the logic for the standalone Drive auth page.
• entrypoints/drive-auth/index.html
  • Removed the entire file, which was the HTML structure for the standalone Drive auth page.
• entrypoints/drive-auth/index.ts
  • Removed the entire file, which was the entrypoint for the standalone Drive auth page.
• entrypoints/drive-auth/style.css
  • Removed the entire file, which contained the styles for the standalone Drive auth page.
• entrypoints/drive/drive_backup.ts
  • Internalized the DriveBackupListPage type by removing its export.
• entrypoints/drive/types.ts
  • Internalized MIN_RETENTION_COUNT and MAX_RETENTION_COUNT constants by removing their exports.
• entrypoints/options/settings_page.ts
  • Internalized the setStatus function by removing its export.
• entrypoints/ui/notifications.ts
  • Internalized the SnackbarNotifierOptions type by removing its export.
• tests/e2e/extension.spec.ts
  • Modified tab query logic to check pendingUrl in addition to url.
  • Introduced expect.poll for more robust waiting in tab restoration tests.
• vitest.config.ts
  • Removed entrypoints/drive-auth/index.ts and entrypoints/drive-auth/drive_auth_page.ts from test coverage exclusion.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily focuses on removing the standalone drive-auth entrypoint, consolidating all Google Drive authentication, backup, and restore user interface elements into the existing options page. This change is reflected across documentation files (README.md, TESTING.md, docs/DRIVE_BACKUP_PLAN.md, docs/DRIVE_BACKUP_SPEC.md, docs/architecture.md), the vitest.config.ts file, and by the complete deletion of all files within the entrypoints/drive-auth/ directory. Additionally, several types and functions in entrypoints/drive/drive_backup.ts, entrypoints/drive/types.ts, entrypoints/options/settings_page.ts, and entrypoints/ui/notifications.ts were refactored to be internal to their modules. The E2E tests in tests/e2e/extension.spec.ts were also updated to enhance the robustness of tab restoration checks by considering both tab.url and tab.pendingUrl and utilizing expect.poll for asynchronous waits. A review comment points out that the DriveBackupListPage type in entrypoints/drive/drive_backup.ts was made internal but is still used by an exported function, which could lead to TypeScript compilation errors, and suggests re-exporting it.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.8%. Comparing base (f483d5e) to head (79e40ac).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main     #29   +/-   ##
=====================================
  Coverage   94.8%   94.8%           
=====================================
  Files         18      18           
  Lines       2132    2132           
  Branches     556     556           
=====================================
  Hits        2023    2023           
  Misses        97      97           
  Partials      12      12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.