Skip to content

Conversation

vinta
Copy link
Owner

@vinta vinta commented Jun 17, 2025

No description provided.

vinta and others added 3 commits June 18, 2025 01:42
- Run tests on all branches and pull requests
- Test against Node.js 18.x, 20.x, and 22.x
- Run build and test commands

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
- Install Playwright browsers with system dependencies
- Fixes browser test failures in GitHub Actions

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Add comprehensive CI pipeline with build, lint, and test jobs for pull requests and pushes to master/main branches.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@vinta vinta self-assigned this Jun 17, 2025
Add comprehensive CI pipeline with:
- Build, lint, and test jobs for Node.js
- Concurrency control to cancel previous builds
- Support for Node.js versions 18.x, 20.x, 22.x, and latest
- Triggers on push to master and all pull requests

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
vinta and others added 7 commits June 18, 2025 03:15
- Trigger on version tags (v*)
- Add npm provenance for supply chain security
- Include security checks: npm audit, secret scanning, package verification
- Add version validation to ensure tag matches package.json
- Configure for npm-production environment with granular access token

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
- Add [email protected] as dev dependency
- Configure unicorn/prefer-node-protocol rule to enforce node: prefix for built-in modules
- Apply rule to both TypeScript and JavaScript files

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
- Rename publish script to publish-package to avoid npm publish conflict
- Merge postversion functionality directly into publish-package script
- Remove separate update-version.js script
- Ensure all version updates happen before git commit and tag
- Update pack script names to pack-extension for clarity

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
- Add .claude/instructions.md for meta-instructions about Claude's behavior
- Refine CLAUDE.md to be more concise and project-focused
- Update commands to reflect current script names
- Remove emojis from documentation
- Add cross-references using @ syntax
- Separate general preferences from project-specific guidance

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
vinta and others added 2 commits June 18, 2025 05:02
- Add lint and lint:fix npm scripts
- Fix ESLint warnings by removing unused disable directives
- Add eslint-disable comment for this-alias (kept for potential future use)
- Verify no node: prefix violations exist
- Update TODO.md: move completed task to Completed section
- Add note about maintaining TODO.md organization
- Remove emoji from TODO.md

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
vinta and others added 2 commits June 18, 2025 05:08
…pt files

- Update vite-plugin-dts to output .d.ts files in dist/ instead of dist/types/
- Update package.json exports to reference new type declaration paths
- This follows standard npm package conventions for better IDE discovery
- Reduces directory nesting and simplifies package structure

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@vinta vinta requested a review from Copilot June 17, 2025 21:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR, titled "Feature/ci", introduces several changes primarily focused on updating CI/CD workflows, packaging scripts, and minor file structure adjustments. Key changes include updated output paths for type declarations, new GitHub Action workflows for publishing and continuous integration, and revisions to packaging scripts and related configuration files.

Reviewed Changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vite.config.ts Updated dts output path from "dist/types" to "dist"
src/shared/index.ts Minor formatting changes and removal of eslint-disable comments
src/node/index.ts & src/node/cli.ts Consistent quoting and cleanup of console logging comments
scripts/publish-package.js New version-management script with version validation logic
scripts/pack-extension-chrome.sh Updated zip command exclusion options and messaging
scripts/pack-chrome-simple.sh Removed obsolete packaging script
package.json Updated export paths, added new scripts, and new eslint plugin
eslint.config.js Integrated unicorn plugin and associated rule adjustments
Other files (.prettierrc.json, workflows, etc.) Various configuration updates to support new CI/CD workflows
Comments suppressed due to low confidence (2)

vite.config.ts:91

  • Changing the output directory for type declarations could break existing type reference paths. Please confirm that all paths (e.g., in package.json and documentation) have been updated accordingly.
      outDir: 'dist',

scripts/pack-extension-chrome.sh:13

  • The exclusion options for the zip package have been reduced compared to the previous version, which might unintentionally include undesired files. Consider reinstating the previously excluded patterns if they are still needed.
  -x "*.DS_Store"

@vinta vinta merged commit 6af4fe2 into master Jun 17, 2025
7 checks passed
@vinta vinta deleted the feature/ci branch June 17, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant