Skip to content

Conversation

@monkpow
Copy link
Collaborator

@monkpow monkpow commented Mar 7, 2019

@raphaeleidus @amir-arad How does this address your concerns on issue #399 ?

@amir-arad: I've used some of the code from your PR in this test. If you'd like credit on the commit log, can you submit a patch for just the test, and I'll accept it right away.

Thanks

@amir-arad
Copy link

It's not relevant for my project. I ended up writing my own proxy, it's easier.
no need for credit on the code, nice of you to offer. go ahead with the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants