Open
Conversation
Signed-off-by: Julien 'Lta' BALLET <contact@lta.io>
Signed-off-by: Julien 'Lta' BALLET <contact@lta.io>
Signed-off-by: Julien 'Lta' BALLET <contact@lta.io>
chouquette
reviewed
Apr 27, 2017
|
|
||
| AM_CONDITIONAL([DEBUG], [test x"$enable_debug" == x"yes"]) | ||
| AM_CONDITIONAL([PROGRAMS], [test x"$enable_programs" != x"no"]) | ||
| AM_CONDITIONAL([TESTS], [test x"$enable_tests" != x"no"]) |
Collaborator
There was a problem hiding this comment.
Doesn't this imply default=yes ?
| AC_ARG_WITH([urandom], | ||
| [AS_HELP_STRING([--with-urandom=PATH], | ||
| AC_ARG_WITH([urandom], | ||
| [AS_HELP_STRING([--with-urandom=PATH], |
Collaborator
There was a problem hiding this comment.
nitpicking, but unrelated
| dsm_lookup_SOURCES = bin/lookup.c | ||
|
|
||
| if TESTS | ||
| bin_PROGRAMS += all_tests |
Collaborator
There was a problem hiding this comment.
Is the test scenario you're aiming for something like
- ../configure --enable-tests
- make
- ./tests
Or is make check considered?
To be honest I don't have a strong opinion on wether make check should be used when it's not actually running the tests, but this means writing a test harness for cmocka IIUC
| @@ -0,0 +1,14 @@ | |||
| #include <stdarg.h> | |||
Collaborator
There was a problem hiding this comment.
nitpick: Missing license header
Contributor
|
Seems a great idea! |
ghost
approved these changes
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed quite some time ago with @jbkempf, I said I would start to add a bunch of tests to this little beast.
Very little of the interesting parts of the code can be tested this way, so it'll need to be paired with a higher level integration testing suite. But this is already something.