Skip to content

Conversation

@jckras
Copy link
Member

@jckras jckras commented Oct 31, 2025

(https://viam.atlassian.net/browse/APP-9925) - This PR adds the hotspot provisioning example app to the examples found in the flutter sdk. I took this exact example app from the hotspot provisioning package https://github.com/viamrobotics/viam_flutter_hotspot_provisioning_widget/tree/main/example/hotspot_provisioning and added it to the same directory as the other example apps that live in the flutter sdk.

One thing to note about the dependencies here - there's a circular dependency between these packages. The viam_flutter_hotspot_provisioning_widget package depends on viam_sdk, so if I set viam_sdk to use a local path in this example, it creates a conflict where the example would reference the local viam_sdk while the hotspot provisioning widget references the published version. To avoid version mismatches, I had to set viam_sdk to reference a published version instead of the local path.

Also note: I know this is a large amount of files because I am importing an entire example app. Let me know if there is a better way to go about this. The main changes exist in lib/, README.md and pubspec.yaml.

@jckras jckras marked this pull request as ready for review October 31, 2025 20:42
@jckras jckras requested a review from a team as a code owner October 31, 2025 20:42
@jckras jckras requested review from njooma and stuqdog October 31, 2025 20:42
@jckras jckras marked this pull request as draft October 31, 2025 20:43
@jckras jckras marked this pull request as ready for review October 31, 2025 21:07
@jckras
Copy link
Member Author

jckras commented Nov 3, 2025

Video running example app on ios:

ScreenRecording_11-03-2025.09-21-36_1.MP4

@jckras jckras requested a review from stevebriskin November 3, 2025 16:00
@jckras
Copy link
Member Author

jckras commented Nov 3, 2025

@stevebriskin adding you as a reviewer since you requested this. let me know if there's something different you were thinking

Comment on lines 13 to 14


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - del extra lines

Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable % kevin's nit (which i agree with)

@jckras jckras merged commit 5424e7f into viamrobotics:main Nov 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants