-
Notifications
You must be signed in to change notification settings - Fork 31
Update flutter_sdk example to include hotspot provisioning widget #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Video running example app on ios: ScreenRecording_11-03-2025.09-21-36_1.MP4 |
|
@stevebriskin adding you as a reviewer since you requested this. let me know if there's something different you were thinking |
example/README.md
Outdated
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - del extra lines
njooma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable % kevin's nit (which i agree with)
(https://viam.atlassian.net/browse/APP-9925) - This PR adds the hotspot provisioning example app to the examples found in the flutter sdk. I took this exact example app from the hotspot provisioning package https://github.com/viamrobotics/viam_flutter_hotspot_provisioning_widget/tree/main/example/hotspot_provisioning and added it to the same directory as the other example apps that live in the flutter sdk.
One thing to note about the dependencies here - there's a circular dependency between these packages. The
viam_flutter_hotspot_provisioning_widgetpackage depends onviam_sdk, so if I setviam_sdkto use a local path in this example, it creates a conflict where the example would reference the localviam_sdkwhile the hotspot provisioning widget references the published version. To avoid version mismatches, I had to setviam_sdkto reference a published version instead of the local path.Also note: I know this is a large amount of files because I am importing an entire example app. Let me know if there is a better way to go about this. The main changes exist in
lib/,README.mdandpubspec.yaml.