-
Notifications
You must be signed in to change notification settings - Fork 84
Update PointCloud type to support client-side rendering #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DTCurrie
wants to merge
5
commits into
main
Choose a base branch
from
update-pointcloud-to-use-repeated-floats-not-bytes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0286b7d
Use repeated float for point cloud data instead of bytes
DTCurrie df8e08c
Don't use repeated float, use header metadata
DTCurrie fa9e304
fix enum
DTCurrie 19d209b
cleanup
DTCurrie dcef9d7
Merge branch 'main' into update-pointcloud-to-use-repeated-floats-not…
DTCurrie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not a frame of the sensor that captured it? that's what we currently do with pointclouds in the visualizer. pointclouds are returned from camera methods in local space and we child them to the camera frame. it allows us to show both local and world pose information
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess though if this is just modifying the proto message then we can still determine the frame using the above strategy. would viewpoint here potentially mean some other kind of offset with respect to the sensor frame?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do either, but I am thinking more from an ergonomics standpoint. I imagine it would be easier to work with just the pose than the entire frame object when using this API. I also feel like the
Poseis less likely to change (at least in the near future) as opposed to theFrame.