Skip to content

Conversation

@sharmagot
Copy link
Collaborator

@sharmagot sharmagot commented Aug 7, 2025

  1. Vertica supports TOTP-based authentication as part of multi-factor authentication (MFA).

  2. To enable MFA for a new user, create the user with the following command:

CREATE USER ravi IDENTIFIED BY 'vertica' ENFORCEMFA;

  1. After the user is created, the generated secret key must be added to a TOTP app like Microsoft Authenticator.

  2. The TOTP app will generate a time-based code every 30 seconds, which is required during user login.

Screenshot of testcase :
totp_screenshot

@sharmagot sharmagot requested a review from ssharieff21 August 7, 2025 10:03
@CLAassistant
Copy link

CLAassistant commented Aug 7, 2025

CLA assistant check
All committers have signed the CLA.

@sharmagot sharmagot requested a review from vipulkotfi August 12, 2025 03:56
@sharmagot sharmagot requested a review from viveknair1 August 22, 2025 08:06
@sharmagot sharmagot requested a review from mkottakota1 November 6, 2025 09:32
@mkottakota1
Copy link
Collaborator

Why Go Unit tests "Corresponding Go unit tests have been added to validate the TOTP-based authentication flow." ??

Please correct this in the description.

Copy link
Collaborator

@mkottakota1 mkottakota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, excellent structure — just minor cleanups needed for polish and safety

@sharmagot
Copy link
Collaborator Author

Why Go Unit tests "Corresponding Go unit tests have been added to validate the TOTP-based authentication flow." ??

Please correct this in the description.

@sharmagot sharmagot closed this Nov 13, 2025
@sharmagot
Copy link
Collaborator Author

Why Go Unit tests "Corresponding Go unit tests have been added to validate the TOTP-based authentication flow." ??

Please correct this in the description.

Corrected the description .

@sharmagot sharmagot reopened this Nov 13, 2025
@mkottakota1
Copy link
Collaborator

Since, the Git pipelines are failing, I would like to see the local test suite results for the new and existing test cases to avoid regressions.

@sharmagot
Copy link
Collaborator Author

Hi @mkottakota1

please find the regression run screenshot.
python_full_regration

@mkottakota1
Copy link
Collaborator

  1. Vertica supports TOTP-based authentication as part of multi-factor authentication (MFA).
  2. To enable MFA for a new user, create the user with the following command:

CREATE USER ravi IDENTIFIED BY 'vertica' ENFORCEMFA;

  1. After the user is created, the generated secret key must be added to a TOTP app like Microsoft Authenticator.
  2. The TOTP app will generate a time-based code every 30 seconds, which is required during user login.

Screenshot of testcase : MFA_Sceenshot

  1. Vertica supports TOTP-based authentication as part of multi-factor authentication (MFA).
  2. To enable MFA for a new user, create the user with the following command:

CREATE USER ravi IDENTIFIED BY 'vertica' ENFORCEMFA;

  1. After the user is created, the generated secret key must be added to a TOTP app like Microsoft Authenticator.
  2. The TOTP app will generate a time-based code every 30 seconds, which is required during user login.

Screenshot of testcase : MFA_Sceenshot

Fix the test case name

@mkottakota1
Copy link
Collaborator

  1. Vertica supports TOTP-based authentication as part of multi-factor authentication (MFA).
  2. To enable MFA for a new user, create the user with the following command:

CREATE USER ravi IDENTIFIED BY 'vertica' ENFORCEMFA;

  1. After the user is created, the generated secret key must be added to a TOTP app like Microsoft Authenticator.
  2. The TOTP app will generate a time-based code every 30 seconds, which is required during user login.

Screenshot of testcase : MFA_Sceenshot

  1. Vertica supports TOTP-based authentication as part of multi-factor authentication (MFA).
  2. To enable MFA for a new user, create the user with the following command:

CREATE USER ravi IDENTIFIED BY 'vertica' ENFORCEMFA;

  1. After the user is created, the generated secret key must be added to a TOTP app like Microsoft Authenticator.
  2. The TOTP app will generate a time-based code every 30 seconds, which is required during user login.

Screenshot of testcase : MFA_Sceenshot

Fix the test case name

@sharmagot
Copy link
Collaborator Author

  1. Vertica supports TOTP-based authentication as part of multi-factor authentication (MFA).
  2. To enable MFA for a new user, create the user with the following command:

CREATE USER ravi IDENTIFIED BY 'vertica' ENFORCEMFA;

  1. After the user is created, the generated secret key must be added to a TOTP app like Microsoft Authenticator.
  2. The TOTP app will generate a time-based code every 30 seconds, which is required during user login.

Screenshot of testcase : MFA_Sceenshot

  1. Vertica supports TOTP-based authentication as part of multi-factor authentication (MFA).
  2. To enable MFA for a new user, create the user with the following command:

CREATE USER ravi IDENTIFIED BY 'vertica' ENFORCEMFA;

  1. After the user is created, the generated secret key must be added to a TOTP app like Microsoft Authenticator.
  2. The TOTP app will generate a time-based code every 30 seconds, which is required during user login.

Screenshot of testcase : MFA_Sceenshot

Fix the test case name

Hi Mani , I have updated the code based on your review comment.

@sharmagot sharmagot force-pushed the VE-4892527-Python-Driver-MFA branch from d60fecc to f11da77 Compare November 26, 2025 05:51
cur.execute("GRANT AUTHENTICATION totp_auth TO totp_user")

# Generate TOTP
import pyotp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyotp is imported 2 times.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected it .

import os
import pyotp
import pytest
import vertica_python
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep only required imports.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mani , Kept only required import .

Copy link
Collaborator

@mkottakota1 mkottakota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Reviewed the code changes and changes are look good to me.

@sharmagot sharmagot force-pushed the VE-4892527-Python-Driver-MFA branch 4 times, most recently from 243d519 to 93afc78 Compare November 26, 2025 12:48
@sharmagot sharmagot force-pushed the VE-4892527-Python-Driver-MFA branch from 93afc78 to 0282333 Compare November 26, 2025 13:45
@sharmagot sharmagot merged commit c42d663 into master Nov 26, 2025
1 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants