Fix Rclone::check to return false on differences instead of throwing - #15
Fix Rclone::check to return false on differences instead of throwing#15insign wants to merge 1 commit into
Rclone::check to return false on differences instead of throwing#15Conversation
Previously, rclone exit code 1 (differences found) caused a SyntaxErrorException. Now, check() catches this exception and returns false if it's not a syntax error. Added setProcessManager() for better testability. Added unit tests covering difference, syntax error, and success scenarios.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
The
rclone checkcommand exits with code 1 when differences are found. Previously,Flyclonetreated this as aSyntaxErrorException, causingcheck()to throw an exception instead of returningfalse.This PR modifies
Rclone::checkto catchSyntaxErrorExceptionand inspect the message. If the message indicates differences (or does not contain "Error:"), it returnsfalse. If it indicates a syntax error, it re-throws.Added
setProcessManagerto allow dependency injection for testing.Added unit test
tests/Unit/CheckCommandTest.phpto verify the fix.PR created automatically by Jules for task 2927449446816599270 started by @insign