Skip to content

fix(deps): update dependency @vercel/style-guide to v6 - autoclosed #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(deps): update dependency @vercel/style-guide to v6 - autoclosed #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"prettier": "@vercel/style-guide/prettier",
"devDependencies": {
"@changesets/cli": "2.28.1",
"@vercel/style-guide": "5.2.0",
"@vercel/style-guide": "6.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project's Node version requirement (>=18) is less strict than what @vercel/style-guide 6.0.0 requires (>=18.18), potentially causing runtime issues for users with Node 18.0-18.17.

View Details
📝 Patch Details 
diff --git a/package.json b/package.json
index d1bcd69..4831161 100644
--- a/package.json
+++ b/package.json
@@ -44,6 +44,6 @@
   },
   "packageManager": "[email protected]",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   }
 }

Analysis

The update to @vercel/style-guide 6.0.0 introduces a more restrictive Node.js version requirement (>=18.18) than what the project currently specifies in its engines field (>=18). This version mismatch creates a compatibility gap where the project claims to support Node.js 18.0.0 and above, but the @vercel/style-guide dependency actually requires Node.js 18.18.0 or later.

This discrepancy can lead to runtime failures if users attempt to run the project with Node versions 18.0.0 through 18.17.x, which satisfy the project's stated requirements but fail the dependency's requirements. The fix is to update the project's Node version requirement to match or exceed the most restrictive dependency requirement: "node": ">=18.18".

"eslint": "8.56.0",
"eslint-config-custom": "workspace:*",
"husky": "9.1.7",
Expand Down
Loading
Loading