Remove marking revalidate: 0 or expire in 5 min as dynamic #86326
+1
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the early development stage of the cache component (Dynamic I/O), PR #71285 makes Next.js not cache cache that either revalidate immediately (revalidate: 0), or expire in 5 min (expire < DYNAMIC_EXPIRE), besides it throws it as "without a Suspense boundary nor a "use cache" ". E.g., using the default
cacheLife("seconds")profile, which has expire: 1 minute, Next.JS will mark is dynamic and throw above error.Multiple issues have mentioned it: #74158, #74534, #78269.
For best going forward, unless better docs, reason, and bypass method in place, I think removing it makes cache component more predictable and gain more traction