Skip to content

[test] Run Cache Components tests with Turbopack #86295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from
+7 −3
Draft

[test] Run Cache Components tests with Turbopack #86295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,7 @@ jobs:
export __NEXT_CACHE_COMPONENTS=true
export __NEXT_EXPERIMENTAL_DEBUG_CHANNEL=true
export NEXT_EXTERNAL_TESTS_FILTERS="test/cache-components-tests-manifest.json"
export IS_WEBPACK_TEST=1
Copy link
Contributor

@vercel vercel bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export IS_WEBPACK_TEST=1
export IS_TURBOPACK_TEST=1

Inconsistent bundler configuration in cache-components tests: test-new-tests-deploy-cache-components is using IS_WEBPACK_TEST=1 while other cache-components jobs use IS_TURBOPACK_TEST=1, which contradicts the stated goal of updating the configuration to match current Next.js defaults with Turbopack.

View Details

Analysis

Inconsistent bundler configuration in cache-components tests

What fails: test-new-tests-deploy-cache-components workflow job uses IS_WEBPACK_TEST=1 while all other cache-components test jobs (test-cache-components-integration, test-cache-components-dev, test-cache-components-prod) use IS_TURBOPACK_TEST=1, causing cache-components deployed tests to run with the wrong bundler.

How to reproduce: Examine the workflow file at .github/workflows/build_and_test.yml and compare line 707 (in test-new-tests-deploy-cache-components job) with lines 939, 963, and 988 (in the other cache-components jobs).

Expected vs actual:

  • Expected: All four cache-components test jobs should use the same bundler configuration (IS_TURBOPACK_TEST=1) to match the stated goal of using Turbopack as the default bundler in Next.js
  • Actual: One job was accidentally left using IS_WEBPACK_TEST=1 in commit 03e0dff "[test] Run Cache Components tests with Turbopack", which updated the other three cache-components jobs but missed this one

Context: This was an incomplete implementation - the commit updated the three test-cache-components-* jobs to use Turbopack but accidentally added IS_WEBPACK_TEST=1 to test-new-tests-deploy-cache-components instead of updating it to IS_TURBOPACK_TEST=1.

Copy link
Member Author

@eps1lon eps1lon Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just encoding the current default for visibility.

export NEXT_E2E_TEST_TIMEOUT=240000
export GH_PR_NUMBER=${{ github.event.pull_request && github.event.pull_request.number || '' }}
node scripts/test-new-tests.mjs \
Expand Down Expand Up @@ -935,7 +936,7 @@ jobs:
export __NEXT_CACHE_COMPONENTS=true
export __NEXT_EXPERIMENTAL_DEBUG_CHANNEL=true
export NEXT_EXTERNAL_TESTS_FILTERS="test/cache-components-tests-manifest.json"
export IS_WEBPACK_TEST=1
export IS_TURBOPACK_TEST=1

node run-tests.js \
--timings \
Expand All @@ -959,7 +960,7 @@ jobs:
export __NEXT_EXPERIMENTAL_DEBUG_CHANNEL=true
export NEXT_EXTERNAL_TESTS_FILTERS="test/cache-components-tests-manifest.json"
export NEXT_TEST_MODE=dev
export IS_WEBPACK_TEST=1
export IS_TURBOPACK_TEST=1

node run-tests.js \
--timings \
Expand All @@ -984,7 +985,7 @@ jobs:
export __NEXT_EXPERIMENTAL_DEBUG_CHANNEL=true
export NEXT_EXTERNAL_TESTS_FILTERS="test/cache-components-tests-manifest.json"
export NEXT_TEST_MODE=start
export IS_WEBPACK_TEST=1
export IS_TURBOPACK_TEST=1

node run-tests.js \
--timings \
Expand Down
3 changes: 3 additions & 0 deletions test/cache-components-tests-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,8 +338,11 @@
"test/integration/app-types/app-types.test.ts",
"test/production/app-dir-edge-runtime-with-wasm/index.test.ts",
"test/production/app-dir-prevent-304-caching/index.test.ts",
"test/production/app-dir/actions-tree-shaking/basic/basic-edge.test.ts",
"test/production/app-dir/actions-tree-shaking/mixed-module-actions/mixed-module-actions-edge.test.ts",
"test/production/app-dir/actions-tree-shaking/reexport/reexport-edge.test.ts",
"test/production/app-dir/actions-tree-shaking/reexport/reexport.test.ts",
"test/production/app-dir/actions-tree-shaking/shared-module-actions/shared-module-actions-edge.test.ts",
"test/production/app-dir/actions-tree-shaking/use-effect-actions/use-effect-actions-edge.test.ts",
"test/production/app-dir/app-fetch-build-cache/app-fetch-build-cache.test.ts",
"test/production/app-dir/build-output-tree-view/build-output-tree-view.test.ts",
Expand Down
Loading