fix: resolve npm React peer dependency conflict - #758
Open
JJordan0C wants to merge 1 commit into
Open
Conversation
Contributor
|
@JJordan0C is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix npm dependency resolution for generated next-forge projects.
The workspaces pin React to
19.2.4, but packages with React and React DOM peer dependencies allow npm to select a newerreact-domrelease. That newer release requires the matching newer React version, producing anERESOLVEconflict with the pinned React version.This change adds a root
react-domoverride at19.2.4, keeping the React pair aligned across every workspace.Related Issues
Closes #753
Checklist
Screenshots (if applicable)
Not applicable.
Validation
bun install --frozen-lockfile --ignore-scriptsbun run testbunx tsupERESOLVEfailure and verified the React conflict no longer occurs with the overrideAdditional Notes
After resolving this React conflict, npm currently reaches the separate OpenAI/Zod conflict tracked in #743 and #746. Applying that independent override during validation allowed
npm installto complete successfully.