test(turbopack): cover package module specifiers in worker URLs#9
Draft
vercel-gh-bot-2[bot] wants to merge 1 commit into
Conversation
Next-Maintainer-Receipt: v1.ojGI4WblTRW96gOPpmw19HmxN8HHA7baxuJVc6SGtcQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this tests
Adds regression coverage for vercel#94015 to the existing App Router worker suite. The fixture models a third-party package with conditional wildcard exports whose client API creates a worker from a bare package module specifier:
The browser assertion requires the packaged worker to start and post
worker-loaded. This is the smallest native equivalent of the verified GraphiQL/monaco-graphqlpath and avoids carrying the full editor dependency graph.Local precedent
The coverage extends
test/e2e/app-dir/worker/worker.test.ts, reusing its real fixture directory,nextTestSetup, browser interaction,beforePageLoadworker request checks, andretry()assertion style.Verification provenance
still_reproduces)7d38f45f66e110739e29c1966f139d86a9355d6b16.2.616.3.0-canary.8880fd3fed693b7aea14b7aed6eab5960ba5d94985(16.3.0-canary.92)The stored verifier reports that the production GraphQL worker URL reaches the unsafe Turbopack
parseRequestURL normalizer on both the reported revision and frozen canary. Runningnode verify.mjsin the materialized reproduction on16.2.6completed the production build and reportedsymptomPresent: true.Commands and results
pnpm test-start-turbo test/e2e/app-dir/worker/worker.test.ts -t 'package module specifiers'Fails on untouched
16.3.0-canary.92at the new assertion, as required for astill_reproducesregression test:pnpm test-dev-turbo test/e2e/app-dir/worker/worker.test.ts -t 'package module specifiers'Also fails at the same assertion in the unminified runtime:
Both pass.
Formatting and lint checks pass for all changed files. Expected CI state is intentionally red for the new assertion in Turbopack development and production modes until the framework bug is fixed; the corresponding webpack modes should remain green.