test: cover ISR index cache key collision#7
Draft
vercel-gh-bot-2[bot] wants to merge 1 commit into
Draft
Conversation
Next-Maintainer-Receipt: v1.XtmmO1UBdhQg42YRNySA21xCqXsktTSVjdtdbVNOVmo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a production App Router regression fixture for the ISR cache-key collision between
/and/index.The fixture has:
revalidate = 1[slug]route withdynamicParams = truenotFound()for the dynamic routeThe test waits for a fresh home generation to become stale, requests
/index, waits for its not-found result, and asserts that/still returns the cached home page with status 200.Test precedent
This uses the native
nextTestSetup({ files: __dirname })production fixture pattern andretry()synchronization used by nearby App Router ISR coverage such astest/production/app-dir/ssg-single-pass/ssg-single-pass.test.ts. It uses no fixed sleeps.Verification evidence
Stored verification vercel#57 against reproduction vercel#59 (
642d9480045b080a6bb855121e16ca8d05d2874f) classified the issue asstill_reproduces.node verify.mjsobservedinitial_home=200,index=200, andfinal_home=404on both the reported16.2.1-canary.18and then-current16.3.0-canary.86.The new test was run on untouched canary parent
80fd3fed693b7aea14b7aed6eab5960ba5d94985(16.3.0-canary.92) in both production bundler modes:Both builds and servers completed normally, then the regression assertion failed for the expected reason:
Formatting, ESLint, and
git diff --checkalso completed successfully.Expected CI state
This is intentionally test-only. The focused production test is expected to fail with both Turbopack and webpack until the framework cache-key collision is fixed.