fix: clamp spectrum band bins against Nyquist to prevent out-of-bounds read#135
Open
mvanhorn wants to merge 1 commit into
Open
fix: clamp spectrum band bins against Nyquist to prevent out-of-bounds read#135mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
|
@mvanhorn is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NativeSdkSpectrumComputeBandscomputed each band'slow_binfrom a log-spaced frequency and only clampedhigh_binagainst the Nyquist limit. For the top bands,low_bincan exceedFFT_SIZE/2 - 1, so the inner accumulation loop read past the end of the magnitude buffer. This clampslow_binagainst the samemax_binand skips (writes 0 for) any band whose range starts beyond Nyquist.Closes #108