feat: add declared size support for lazy files#220
Open
Ehesp wants to merge 1 commit into
Open
Conversation
|
@Ehesp is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for defining a lazy file with metdaata, including a size.
I've got a use-case using the GitHub tree api where I get the file names, but also the size of the file, see https://api.github.com/repos/vercel-labs/just-bash/git/trees/HEAD
When defining in-memory files, such as:
When
stat()(etc) is called on the FS, it performs a fetch request to return metadata (e.g size). So if the user runs als -lacommand on a directory with say 100 lazy-loaded files, this would be 100 network requests.This PR adds support for defining the metadata upfront, so content loading is deferred until the content itself is actually needed, e.g:
With this, the content isn't fetched until it's actually needed since we provide the metadata upfront.
Without this, I basically need to re-implement my own file system instance, re-building all of the complexity which the built in ones provided out of the box.