Skip to content

fix: always add model name to experiment run - #34

Merged
paoloricciuti merged 6 commits into
mainfrom
always-add-model-name-in-result
Feb 7, 2026
Merged

fix: always add model name to experiment run#34
paoloricciuti merged 6 commits into
mainfrom
always-add-model-name-in-result

Conversation

@paoloricciuti

Copy link
Copy Markdown
Collaborator

I think it's nice to split the results by model to keep them organized...we should also add the model to the result imho

@gaojude

gaojude commented Feb 7, 2026

Copy link
Copy Markdown
Collaborator

cc @allenzhou101 this might break result parsing for playground UI due to changes to folder structure

@paoloricciuti

Copy link
Copy Markdown
Collaborator Author

If you think could be considered a breaking change for some people we can push this over (or use a minor instead of a patch to signal that)

@paoloricciuti

Copy link
Copy Markdown
Collaborator Author

Oh actually I thought playground was just a playground app...just now I realize is actually a package...let me also update that

Comment thread .changeset/chatty-cobras-decide.md Outdated
@paoloricciuti

Copy link
Copy Markdown
Collaborator Author

And btw this was already possible before...but only when multiple models were used...this PR just unify the behavior (which is also better for the playground because it doesn't have to check multiple kind of paths...even tho since models have slashes in them it will create folders which is a bit annoying)

@paoloricciuti

Copy link
Copy Markdown
Collaborator Author

Fixed the playground...here's how it looks like in my test

image

Please let me know if I should remove the model name from the experiment in the playground (but i think it's actually pretty nice you can have that)

@gaojude

gaojude commented Feb 7, 2026

Copy link
Copy Markdown
Collaborator

Lgtm

@paoloricciuti
paoloricciuti merged commit 6839841 into main Feb 7, 2026
4 checks passed
@github-actions github-actions Bot mentioned this pull request Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants