fix: always add model name to experiment run - #34
Merged
Conversation
gaojude
approved these changes
Feb 7, 2026
Collaborator
|
cc @allenzhou101 this might break result parsing for playground UI due to changes to folder structure |
Collaborator
Author
|
If you think could be considered a breaking change for some people we can push this over (or use a minor instead of a patch to signal that) |
Collaborator
Author
|
Oh actually I thought playground was just a playground app...just now I realize is actually a package...let me also update that |
paoloricciuti
commented
Feb 7, 2026
Collaborator
Author
|
And btw this was already possible before...but only when multiple models were used...this PR just unify the behavior (which is also better for the playground because it doesn't have to check multiple kind of paths...even tho since models have slashes in them it will create folders which is a bit annoying) |
Collaborator
Author
Collaborator
|
Lgtm |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I think it's nice to split the results by model to keep them organized...we should also add the model to the result imho