fix: nested eval directory with housekeeping and result checking - #198
Open
RihanArfan wants to merge 1 commit into
Open
fix: nested eval directory with housekeeping and result checking#198RihanArfan wants to merge 1 commit into
RihanArfan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes handling of nested eval directories (e.g.
caching/cache-bypass,frameworks/h3) across result caching, housekeeping, and refingerprinting.Eval fixtures can be organized into nested subdirectories (e.g.
evals/<group>/<name>/), andsaveResults()preserves this hierarchy on disk underresults/<experiment>/<timestamp>/<group>/<name>/. However, several consumer paths relied on a single-levelreaddirSync(tsDir):housekeep): A 1-levelreaddirencountered the parent group directory (e.g.caching/), which lacks summary.json at the group root. It evaluated the group directory as an incomplete result and recursively rmSync'd it, deleting all valid results beneath it.scanReusableResults): Evaluated only 1-level directory entries against fingerprint keys, causing nested evals to never match and preventing result caching.carryForwardConfigChanges): Evaluated only 1-level directory entries, silently dropping nested evals and failing to carry forward benign config bumps.