Initial how-to guide of implementing deposit price adjuster#65
Open
bjarnef wants to merge 15 commits into
Open
Initial how-to guide of implementing deposit price adjuster#65bjarnef wants to merge 15 commits into
bjarnef wants to merge 15 commits into
Conversation
mattbrailsford
requested changes
Mar 1, 2021
mattbrailsford
left a comment
Member
There was a problem hiding this comment.
Some things to be fixed, but also some misunderstanding of how price adjustments work.
Also, might be worth reviewing the updates to the price adjustments key concept docs and see if this is now covered by those docs, or whether we think this how to guide is still useful.
This reverts commit a5a6783.
…into feature/deposit-price-adjustment
Contributor
Author
|
@mattbrailsford I have updated the docs. I think it would be a great supplement to the basic key concept of a concrete use-case, where you want to add a deposit, e.g. when with rental of producs or maybe pre-order an expensive product? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some initial documentation of a deposit price adjustment.