fix(retain): enqueue relink victims before delta chunk deletion - #3420
Open
koriyoshi2041 wants to merge 1 commit into
Open
fix(retain): enqueue relink victims before delta chunk deletion#3420koriyoshi2041 wants to merge 1 commit into
koriyoshi2041 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Delta retain deletes changed and removed chunks directly. The cascade drops their memory links, but unlike full document replacement, this path does not enqueue surviving units whose outgoing temporal or semantic links pointed at the deleted facts. Graph maintenance runs afterwards, but by then the links needed to discover those victims are gone.
This is the relink-victim residue called out as out of scope in #3384.
Fix
Reuse the outgoing fact IDs already collected for observation invalidation and enqueue relink victims before the chunk/link cascade. The store abstraction keeps this a no-op for stores that own links inline.
The existing real-Postgres endpoint-deletion test now also asserts that the surviving source whose outgoing link targeted the deleted chunk is present in
graph_maintenance_queue.Test
uv run pytest tests/test_chunk_storage_delete_ordering.py::test_delete_chunks_by_ids_sweeps_links_on_both_endpoints -q -n 0(1 passed)uv run ruff check hindsight_api/engine/retain/chunk_storage.py tests/test_chunk_storage_delete_ordering.pyuv run ruff format --check hindsight_api/engine/retain/chunk_storage.py tests/test_chunk_storage_delete_ordering.pygit diff --checkFixes the relink-victim follow-up noted in #3384.