-
Notifications
You must be signed in to change notification settings - Fork 1.9k
enhancement(tag_cardinality_limit): Add metric and tag name to tag_value_limit_exceeded_total metric #24236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
enhancement(tag_cardinality_limit): Add metric and tag name to tag_value_limit_exceeded_total metric #24236
Conversation
domalessi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions but looks good
Co-authored-by: domalessi <[email protected]>
|
btw. Should we add more label? This PR introduces two new tags to an internal metric for the tag_cardinality_limit transform. |
| counter!("tag_value_limit_exceeded_total").increment(1); | ||
| counter!( | ||
| "tag_value_limit_exceeded_total", | ||
| "metric_name" => self.metric_name.to_string(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look reasonable. We could have very high cardinality here though, I wonder if we need to gate this behind a config option.
Summary
When using the
tag_cardinality_limittransform, it's difficult to identify which specific metrics and tag keys are hitting the configured value limit. Thetag_value_limit_exceeded_totalmetric only provides a count of exceeded events without context about which metric or tag was blocked, making it challenging to debug and monitor cardinality issues.More in #20084
This PR adds
metric_nameandtag_keylabels to thetag_value_limit_exceeded_totalmetric and allowing:Vector configuration
How did you test this PR?
Build locally based on docs/DEVELOPING.md and start with config mentioned in the previous section :
Result:
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.