Skip to content

chore/validate-apps - #250

Closed
claytonneal wants to merge 2 commits into
masterfrom
chore/validate-apps
Closed

claytonneal wants to merge 2 commits into
masterfrom
chore/validate-apps

Conversation

@claytonneal

Copy link
Copy Markdown
Contributor

Add script and workflow to check if apps are returning http 404/500 etc

@darrenkel

darrenkel commented Jan 30, 2024 •

Copy link
Copy Markdown
Contributor

@claytonneal I believe there is a validation in the validate.ts file:

https://github.com/vechain/app-hub/blob/master/scripts/validate.ts#L110

@libotony

Copy link
Copy Markdown
Member

How about make it a scheduled workflow? I will change the script to check all apps then report all errors.

@libotony

Copy link
Copy Markdown
Member

If I am remembering correctly, one app used cloudflare and checkLink reports error but it works at the browser level, maybe that need extra confirm by human.

@libotony

Copy link
Copy Markdown
Member

How about make it a scheduled workflow? I will change the script to check all apps then report all errors.

script updated #252

Comment on lines +11 to +12
with:
fetch-depth: 0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with:
fetch-depth: 0

validate link does not require full history

Comment on lines +23 to +25
run: npm run validate:links
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: npm run validate:links
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: npm run validate:link

validate link does not need a gh token, PR mode needed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks tony!

@fabiofvc

fabiofvc commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

@claytonneal this issue is super cool! Cant want to see it in prod ;)

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants