Skip to content

docs: weekly review 2026-07-02#136

Open
vasylenko wants to merge 1 commit into
mainfrom
claude/amazing-carson-ywblor
Open

docs: weekly review 2026-07-02#136
vasylenko wants to merge 1 commit into
mainfrom
claude/amazing-carson-ywblor

Conversation

@vasylenko

Copy link
Copy Markdown
Owner

Weekly documentation review against the codebase (2026-07-02).

Change

docs/dev/SPECIFICATION.md — the "Registration-Time Read/Write Gating" section described tests/system/registration-gate.test.ts as defining two constants (EXPECTED_READ_ONLY_TOOLS and EXPECTED_WRITE_TOOLS). The file actually defines three: EXPECTED_READ_ONLY_TOOLS, EXPECTED_OFF_ONLY_TOOLS, and EXPECTED_WRITE_TOOLS. The omission of EXPECTED_OFF_ONLY_TOOLS (which covers bear-capabilities, the discovery tool registered only when edit mode is off) left the spec incomplete.

Scope

Reviewed: README.md, docs/user/NPM.md, docs/dev/SPECIFICATION.md, docs/dev/SECURITY.md, docs/dev/BEAR_DATABASE_SCHEMA.md, docs/dev/MCP_STANDARDS.md, docs/dev/CODE_STYLE.md, .github/copilot-instructions.md, evals/README.md, CHANGELOG.md, CLAUDE.md. All other docs were accurate.


Generated by Claude Code

…N.md

EXPECTED_OFF_ONLY_TOOLS was omitted from the description of constants in
tests/system/registration-gate.test.ts. The file defines three constants,
not two.
Copilot AI review requested due to automatic review settings July 2, 2026 00:17
@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bear-notes-mcp Ready Ready Preview, Comment Jul 2, 2026 12:17am

@vasylenko

vasylenko commented Jul 2, 2026

Copy link
Copy Markdown
Owner Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the developer specification to accurately reflect the system test that locks in registration-time read/write tool gating, including the “off-only” tool set used when edit mode is disabled.

Changes:

  • Corrected the “Registration-Time Read/Write Gating” section to reference EXPECTED_READ_ONLY_TOOLS, EXPECTED_OFF_ONLY_TOOLS, and EXPECTED_WRITE_TOOLS (matching tests/system/registration-gate.test.ts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants