fix(security): restrict CORS on progress SSE endpoint (#87)#98
Open
evanclan wants to merge 1 commit into
Open
Conversation
The progress stream is consumed via same-origin EventSource, so a wildcard Access-Control-Allow-Origin header is unnecessary and could expose user-scoped progress events to arbitrary origins. Fixes vas3k#87
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Access-Control-Allow-Origin: *header from the progress SSE routeEventSourceusageMotivation
The progress endpoint returns user-scoped progress events for authenticated sessions. A wildcard CORS policy allows any origin to read those event-stream responses, which is broader than needed since the UI already connects via same-origin
/api/progress/....Closes #87.
Test plan
Access-Control-Allow-Origin: *Made with Cursor