Skip to content

docs(vana-sdk): surface VanaStorage as the default storage provider#144

Merged
volod-vana merged 1 commit into
mainfrom
volod/vana-storage-org-default
May 14, 2026
Merged

docs(vana-sdk): surface VanaStorage as the default storage provider#144
volod-vana merged 1 commit into
mainfrom
volod/vana-storage-org-default

Conversation

@volod-vana
Copy link
Copy Markdown
Member

@volod-vana volod-vana commented May 13, 2026

Tiny README clarification — VanaStorage is the default Vana storage provider (talks to storage.vana.org). The big endpoint switch already landed in #145; this is the doc follow-up.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
vana-console Ignored Ignored May 14, 2026 4:20pm
vana-rbac-auditor Ignored Ignored May 14, 2026 4:20pm
vana-vibes-demo Ignored Ignored May 14, 2026 4:20pm

Request Review

@github-actions
Copy link
Copy Markdown

Findings

  • Medium: Upgrading the default endpoint can break reads/deletes of URLs created by older SDK versions. VanaStorage now defaults to https://storage.vana.org at vana-storage.ts:14, but pathFromUrl() still rejects any URL whose host does not exactly match the configured endpoint at vana-storage.ts:296. So a consumer upgrading from the old default may have stored https://storage.vana.com/v1/blobs/... URLs, and download() / delete() will fail client-side before the Worker’s dual-audience migration support can help. Consider allowing storage.vana.com as a legacy host during the migration window, or normalizing legacy URLs to the new endpoint before signing.

Verification

  • Tried running the focused test: npm test --workspace packages/vana-sdk -- packages/vana-sdk/src/storage/tests/vanaStorage.test.ts
  • Could not run because dependencies are not installed here: vitest: not found.

@volod-vana volod-vana force-pushed the volod/vana-storage-org-default branch from 1357e6b to 259b9b6 Compare May 14, 2026 16:20
@volod-vana volod-vana changed the title feat(storage): switch VanaStorage default endpoint to storage.vana.org docs(vana-sdk): surface VanaStorage as the default storage provider May 14, 2026
@volod-vana volod-vana merged commit 1d78ca7 into main May 14, 2026
7 checks passed
@volod-vana volod-vana deleted the volod/vana-storage-org-default branch May 14, 2026 16:22
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant