fix: guard update-data-connect job until consumer scripts ship#73
Closed
tnunamak wants to merge 1 commit into
Closed
fix: guard update-data-connect job until consumer scripts ship#73tnunamak wants to merge 1 commit into
tnunamak wants to merge 1 commit into
Conversation
The update-data-connect job in consumer-update-prs.yml calls scripts/resolve-connectors.js and scripts/generate-platform-registry.js in data-connect main, but those scripts are not yet on main — they are staged in data-connect PR #106. Add a scripts_check step that gates all subsequent steps in the job. When either script is missing, the job emits a notice and exits green instead of failing. Remove this guard after data-connect PR #106 merges. update-context-gateway is unchanged.
Schema Health Check — 6 issue(s) found41/47 scopes consistent | 0 missing schema files | 6 not in Gateway | 0 metadata drift | 0 orphaned View issuesNot registered in Gateway:
|
Member
Author
|
Closing as obsolete. This guard was only needed until data-connect main picked up scripts/resolve-connectors.js and scripts/generate-platform-registry.js via data-connect#106, which is now merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
update-data-connectjob in.github/workflows/consumer-update-prs.ymlcallsscripts/resolve-connectors.jsandscripts/generate-platform-registry.jsinvana-com/data-connect's main branch. Those scripts are staged in data-connect PR #106 but have not yet merged, so any qualifying push to this repo's main will fail the job.This PR adds a
scripts_checkstep that probes for both scripts in the checked-outdata-connect/main. When either is missing, the step emits a GitHub::notice::and all subsequent steps in the job are skipped viaif:gating, so the job exits green. Theupdate-context-gatewayjob is untouched.Why guard vs. remove the job
Per the connector distribution execution plan, the workflow is expected to light up for real once data-connect #106 merges. Removing and re-adding the job would lose history and require an extra PR to re-enable. Guarding is a one-line-condition add to each step and removes cleanly in one follow-up.
Removal instructions
Once data-connect #106 merges and
scripts/resolve-connectors.js+scripts/generate-platform-registry.jsare on data-connectmain:Check for required consumer scriptsstep.if: steps.scripts_check.outputs.present == 'true'condition from every subsequent step inupdate-data-connect.Test plan
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/consumer-update-prs.yml'))").Related
context-gateway/docs/260421-connector-distribution-execution-plan.md(PR 0)