Feedback: tighten vana-connect contributor workflow and docs#43
Closed
callumflack wants to merge 3 commits into
Closed
Feedback: tighten vana-connect contributor workflow and docs#43callumflack wants to merge 3 commits into
callumflack wants to merge 3 commits into
Conversation
Schema Health Check — Non-blocking inherited issues41/47 scopes consistent | 6 inherited Gateway gap(s) | no new blocking issues in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I am opening this
This PR is a discussion vehicle, not a code/docs patch proposal. The branch only contains an empty commit so the feedback can live in the PR description rather than in the repo.
While building and validating the Claude connector, I found the overall connector model strong, but I also hit enough ambiguity in the skill/docs/runtime story that I think it is worth aligning as a team before we add more connectors.
What worked well
What was confusing or not good enough
1. Too many overlapping workflows
In practice I found multiple paths described as if they were all current:
vana sourcesvana connectnode run-connector.cjs ...skills/vana-connect/scripts/run-connector.cjs ...~/.dataconnect/...That makes it hard to know which workflow is actually canonical for contributors working inside this repo today.
2. Runtime/path drift
Some docs still refer to
~/.dataconnect, but on my machine the live runtime state, logs, and results were under~/.vana. That mismatch affects setup, validation, and debugging.3. Validator command drift
I ran into multiple validator entrypoints:
node scripts/validate-connector.cjs ...node skills/vana-connect/scripts/validate.cjs ...node scripts/validate.cjs ...This is unnecessarily confusing.
4. Local repo discovery through
vanais under-documentedOne of the most important practical discoveries was that
vanacan discover connectors from this repo when run from the repo root because it findsregistry.json. That behavior mattered a lot and should be stated more clearly.5. Standalone runner guidance felt stale for the actual repo workflow
In the real Claude build loop, the reliable path was the CLI:
vana connect claude --json --no-inputThe older runner-centric guidance was not the path that got the connector over the line.
6. README feels behind reality
The root README still reads like an older runner-centric architecture in places, while the skill points toward a CLI-first flow.
7. Validator gotchas are not documented clearly enough
I hit a validator behavior where nullable fields listed as
requiredwere effectively treated as missing in output validation. That is the kind of thing contributors should not have to discover the hard way.8. Manual-login-first should be described more explicitly as acceptable
The docs talk a lot about credential flows, but they do not say strongly enough that a connector can still be valid and mergeable if it is manual-login-first because auth is brittle, CAPTCHA-heavy, or tied to third-party providers.
What I had to learn by doing
vanaCLI, not the older standalone runner guidance~/.vana, not~/.dataconnectvanawhen run from this checkoutWhat I would improve
1. Make one workflow canonical
For contributors working in this repo, the docs should state a single primary path such as:
vana sources --jsonvana connect <platform> --json --no-inputnode scripts/validate-connector.cjs ...node skills/vana-connect/scripts/register.cjs ...Everything else should be described as secondary, legacy, or debugging-only if that is the case.
2. Add a short current-architecture section
This should explain:
3. Unify validator guidance
Pick one validator command to recommend in the main workflow and explain when the others are relevant.
4. Add a short known-gotchas section
For example:
5. Update the README to match the actual contributor path
If the intended flow is now CLI-first, the README should reflect that more directly.
6. Add a what-good-looks-like checklist for connector PRs
For example:
7. Be more explicit about acceptable auth tradeoffs
The docs should say plainly that a connector can still be valid and mergeable if:
Question for the team
Would it make sense to tighten the skill/docs around a single contributor workflow now, before adding many more connectors, so contributors spend less time reconciling multiple mental models?