feat(operator): add Prometheus ServiceMonitor support to valkey-operator chart#196
Draft
somaz94 wants to merge 1 commit into
Draft
feat(operator): add Prometheus ServiceMonitor support to valkey-operator chart#196somaz94 wants to merge 1 commit into
somaz94 wants to merge 1 commit into
Conversation
…tor chart Signed-off-by: somaz <genius5711@gmail.com>
94c1ee6 to
ef5448e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional Prometheus ServiceMonitor for the valkey-operator metrics
endpoint, gated on
metrics.serviceMonitor.enabled(defaultfalse).Resolves #191 and clears the
# TODO: prometheus ServiceMonitorplaceholderin values.yaml. Mirrors the recently merged PodDisruptionBudget addition (#193).
The ServiceMonitor targets the existing operator metrics Service (
*-metrics,port
http) and exposes the standard scrape knobs (interval, scrapeTimeout,scheme, tlsConfig, honorLabels, relabelings, metricRelabelings, extra
labels/annotations, namespace). It renders only when both
metrics.enabledandmetrics.serviceMonitor.enabledare true, so the default render is unchanged.Validation (run locally):
helm unittest .— 21 passed (10 new ServiceMonitor cases + existing PDB suite)helm lint .— 0 failedhelm templaterender byte-identical to main except the chart-version label (0.2.1 -> 0.2.2)helm template --set metrics.serviceMonitor.enabled=truerenders a valid ServiceMonitorresolves: #191
Note: Chart.yaml bumps 0.2.1 -> 0.2.2, colliding with my open #195
(topologySpreadConstraints) which also bumps to 0.2.2. They are independent;
whichever merges first, I'll rebase the other to the next patch.