Skip to content

feat(operator): add Prometheus ServiceMonitor support to valkey-operator chart#196

Draft
somaz94 wants to merge 1 commit into
valkey-io:mainfrom
somaz94:feat/operator-servicemonitor
Draft

feat(operator): add Prometheus ServiceMonitor support to valkey-operator chart#196
somaz94 wants to merge 1 commit into
valkey-io:mainfrom
somaz94:feat/operator-servicemonitor

Conversation

@somaz94

@somaz94 somaz94 commented Jun 24, 2026

Copy link
Copy Markdown

Adds an optional Prometheus ServiceMonitor for the valkey-operator metrics
endpoint, gated on metrics.serviceMonitor.enabled (default false).
Resolves #191 and clears the # TODO: prometheus ServiceMonitor placeholder
in values.yaml. Mirrors the recently merged PodDisruptionBudget addition (#193).

The ServiceMonitor targets the existing operator metrics Service (*-metrics,
port http) and exposes the standard scrape knobs (interval, scrapeTimeout,
scheme, tlsConfig, honorLabels, relabelings, metricRelabelings, extra
labels/annotations, namespace). It renders only when both metrics.enabled and
metrics.serviceMonitor.enabled are true, so the default render is unchanged.

Validation (run locally):

  • helm unittest . — 21 passed (10 new ServiceMonitor cases + existing PDB suite)
  • helm lint . — 0 failed
  • default helm template render byte-identical to main except the chart-version label (0.2.1 -> 0.2.2)
  • helm template --set metrics.serviceMonitor.enabled=true renders a valid ServiceMonitor

resolves: #191

Note: Chart.yaml bumps 0.2.1 -> 0.2.2, colliding with my open #195
(topologySpreadConstraints) which also bumps to 0.2.2. They are independent;
whichever merges first, I'll rebase the other to the next patch.

…tor chart

Signed-off-by: somaz <genius5711@gmail.com>
@somaz94 somaz94 force-pushed the feat/operator-servicemonitor branch from 94c1ee6 to ef5448e Compare June 25, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart:valkey-operator Related to the valkey-operator chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Operator: Add prometheus ServiceMonitor support to the valkey-operator chart

2 participants